[Bug 459881] Review Request: rubygem-sqlite3-ruby - Allows Ruby scripts to interface with a SQLite3 database

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459881


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-08-30 00:15:47 EDT ---
A couple of comments:

Please use the macro forms consistently; either "rm" or "%{__rm}" but not both.
 I'd recommend just not using them.

What's the 'pwd' for?

This appears at the end of the build:
  File listed twice: /usr/lib/ruby/gems/1.8/gems/sqlite3-ruby-1.2.2/README.rdoc

The ABI dependency is missing:
  Requires: ruby(abi) = 1.8

Technically the guidelines say that BuildRequires: ruby is mandatory.  I  don't
really see the point, but I'm not sure if there's some possibility that the
dependencies you have already would fail to pull it in.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.