[Bug 473412] Review Request: kopete-cryptography - Encrypts and signs messages in Kopete using the OpenPGP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473412


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #7 from Till Maas <opensource at till.name>  2008-12-01 18:15:17 EDT ---
This seems to be the case:
[OK] %doc does not affect runtime

[UNCLEAR SITUATION]
The provides may not be considered sane afaics:

rpm --provides -qp kopete-cryptography-1.3.0-2.fc10.x86_64.rpm
kcm_kopete_cryptography.so()(64bit)
kopete_cryptography.so()(64bit)

/usr/lib64/kde4/kcm_kopete_cryptography.so
/usr/lib64/kde4/kopete_cryptography.so

It is not clear, whether the fault is at rpm, i.e. it should not make rpms
provide .so files that are not in a directory that is used by ld, but others
seem to think, that this is the right beheaviour. I doubt, that there is a high
potential for problems with these provides, therefore I do not consider this to
be a problem.

The rpmlint warnings about absolute symlinks are now considered to be a bug in
meinproc, therefore they do not block this review:
bug #474057

About the VERBOSE=1 in %build:
This will probably not be necessary in the future, for reference:
bug #474053

Also since this package seems to use default cmake installation procedures,
this  is considered to be not an issue:

{OK} Timestamps preserved with cp and install
If there is a problem with timestamps, then it is a bug in cmake or %cmake
imho.

Btw. if this package will be only in F10 and beyond, you can remove the "mkdir
%{buildroot}" line from %install. Currently afaik it makes only sence to make a
racing condition fail, but with the rpm in F10, the buildroot is located in a
user controlled directory by default instead of /var/tmp. Therefore there is no
such racing condition anymore.

Therefore I see no really blocker to finish the review. This package is now
APPROVED.

The only left problem is, that the plugin is not able to decrypt encrypted
messages. Imho this should be fixed before this package is pushed to F10
updates-testing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.