[Bug 472848] Review Request: jeuclid - MathML rendering solution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472848


Brennan Ashton <bashton at brennanashton.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841




--- Comment #29 from Brennan Ashton <bashton at brennanashton.com>  2008-12-09 19:40:56 EDT ---
(In reply to comment #27)
> $ rpmlint /var/lib/mock//fedora-rawhide-i386/result
> jeuclid-cli.noarch: W: no-documentation
> jeuclid-mathviewer.noarch: W: no-documentation
> jeuclid-fop.noarch: W: no-documentation
> 5 packages and 0 specfiles checked; 0 errors, 3 warnings.
> 
> jeuclid-mathviewer.desktop
> ...
> Icon=/usr/share/icons/hicolor/48x48/apps/jeuclid_48x48.png
> 
> Icon tag with just plain filename without extension is preferred, but the above
> is perfectly acceptable as well.

That is what I thought, but I could not seem to get it to find it, might have
been related to the cache that you were talking about 

> ...
> Categories=Graphics;Math;Science
> 
> Categories should be semicolon-terminated (;).
> 
> 
> License:        ASL 2.0 and SPL
> 
> Where did "SPL" come from?

There is code in Patch 1 that fixes some Apple requirements that is SPL
licensed

> 
> %package        mathviewer
> Summary:        Viewer for MathML files
> Group:          Applications/Publishing
> Requires:       %{name} = %{version}-%{release}
> 
> This is missing Requires: hicolor-icon-theme, because you're putting the icon
> in %{_datadir}/icons/hicolor/* .

Added

> 
> cp src/icons/jeuclid_48x48.png
> $RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/48x48/apps/
> 
> Please use cp -p to preserve the timestamp.
>

Fixed

> %attr(0755,root,root) %{_bindir}/jeuclid-mathviewer
> and
> %attr(0755,root,root) %{_bindir}/jeuclid-cli
> 
> %attr is redundant, you're already installing these scripts with install
> -pm755.

Fixed

> 
> You are missing %post/%postun scripts for updating GTK icon cache, see:
> https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache

Added

Also added the => 1.1 on jakara-commons-cli in build.

This will only build for F10 there are two other packages that are not fixing
bugs in F9 that this depends on.

SRPM: http://bashton.fedorapeople.org/jeuclid-3.1.3-9.fc10.src.rpm
SPEC: http://bashton.fedorapeople.org/jeuclid.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.