[Bug 473367] Review Request: autotrust - DNSKEY trust anchor update utility that uses RFC-5011

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473367





--- Comment #5 from Adam Tkac <atkac at redhat.com>  2008-12-03 08:32:07 EDT ---
"Formal" review:

source files match upstream: YES
package meets naming and versioning guidelines: YES
specfile is properly named, is cleanly written and uses macros consistently: NO
dist tag is present: YES
build root is correct: YES
license field matches the actual license: YES
license is open source-compatible: YES
latest version is being packaged: YES
BuildRequires are proper: YES
compiler flags are appropriate: YES
%clean is present: YES
package builds in mock (Rawhide/x86_64): NO
debuginfo package looks complete: YES
rpmlint is silent: YES
final provides and requires look sane: YES
owns the directories it creates: YES
doesn't own any directories it shouldn't: YES
no duplicates in %files: YES
file permissions are appropriate: YES
code, not content: YES
-------------

Problems:
- no configure flags are needed on rawhide, especially overriding --sysconfdir
(see configure.ac, DEFAULT_CONFIGFILE macro definition)

- package is not buildable on rawhide. New libtool no longer copies
config.{guess,sub}. You have to copy it manually (for example "cp
/usr/share/automake-1.10/config.{guess,sub} ." after you remove them)

- as you wrote above you can "Requires: /etc/cron.daily" instead of "Requires:
anacron". But AFAIK it is not needed because only anacron provides that
directory, no other cron daemon.

Otherwise no problems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.