[Bug 473679] Review Request: xfburn - Simple CD/DVD burning tool based on libburnia

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473679


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |denis at poolshark.org
               Flag|                            |fedora-cvs?




--- Comment #2 from Christoph Wickert <fedora at christoph-wickert.de>  2008-12-03 15:24:50 EDT ---
Thanks for the review.

(In reply to comment #1)
> Fine package. Burnt a CD-RW as a test without any problems. In GNOME.
> 
> Only adjustments I could think of:
>  * Requiring "hicolor-icon-theme" for the icon hierarchy.

Xfburn already requires hicolor-icon theme trough gtk2, but I can add it
explicitly.

>  * Removing the Xfce reference in the summary.
>  * Be careful with the --enable-debug option as not to enable anything you may
> not like. Currently it's okay, though.

This is actually a relict of debuging a reproducable crash in 3.2. Good catch.

> APPROVED


@Denis: I'd like you to be able to do a rebuild of this package when necessary
(soname bump of libburn or libisofs), so I add you as owner.

New Package CVS Request
=======================
Package Name: xfburn
Short Description: Simple CD/DVD burning tool based on libburnia
Owners: cwickert denis
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.