[Bug 469955] Review Request: fprintd - D-Bus service for Fingerprint reader access

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469955


Bastien Nocera <bnocera at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|474573                      |




--- Comment #8 from Bastien Nocera <bnocera at redhat.com>  2008-12-04 10:09:49 EDT ---
Fixed Require: %{name} = %{version}-%{release}
Changed summary for devel files
Added README for pam

(In reply to comment #7)
> two more informal comments on the spec before I run down the checklist:
> - I don't think the explicit Requires: PolicyKit is needed, library deps 
>   should take care of that

Removed

> - The Conflicts: pam_fprint should probably have a comment explaining your
>   rationale from comment #2

I removed the Conflicts. The configuration is different, so I'll add some
release notes.

> rpmlint run: see above
> 
> package name: ok
> spec file name: ok
> packaging guidelines: ok
> license: ok
> license field: not ok
>   the license field says GPLv2+, and the source files say so too,
>   but the license file is GPL3. What gives ?

Fixed, it's supposed to be a GPLv2 COPYING file.

> license file: ok
> spec file language: ok
> spec file legible: ok
> upstream sources: ok
> buildable: ok
> ExcludeArch: ok
> BuildRequires: ok
> locale handling: ok
> shared libs: ok
> relocatable: ok
> directory ownership: not ok
>   -devel should require gtk-doc, for /usr/share/gtk-doc/html

Added.

>   -pam should require pam, for /lib/security

Already dragged in through library deps (PAM libs are in the pam package)

> duplicate files: ok
> permissions: not ok
>   the %files sections for pam and devel need %defattr

Done.

> %clean: ok
> macro use: ok
> permissible content: ok
> large docs: ok
> %doc content: ok
> headers: ok
> static libs: ok
> pc files: ok
> shared libs: ok
> devel deps: ok
> libtool archives: ok
> gui apps: ok
> file ownership: ok
> %install: ok
> utf8 filenames: ok
> 
> summary: some small fixes left

All done!

http://hadess.fedorapeople.org/fprintd/fprintd.spec
http://hadess.fedorapeople.org/fprintd/fprintd-0.1-3.git43fe72a2aa.fc10.src.rpm

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=976118

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.