[Bug 471275] Review Request: mod_scgi - Python implementation of the SCGI protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471275





--- Comment #3 from Lubomir Rintel <lkundrak at v3.sk>  2008-12-05 10:12:24 EDT ---
Seems very well done.
Just two issues:

1.) Please depend on httpd ABI you built against:

This is best done by thepending on the Module Magic Number. This comes from
mod_perl:

Requires:       httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing)

2.) RPMlint warnings:

mod_scgi.i386: E: non-executable-script
/usr/lib/python2.4/site-packages/scgi/scgi_server.py 0644

mod_scgi.i386: E: non-executable-script
/usr/lib/python2.4/site-packages/scgi/quixote_handler.py 0644

What about these? Are they run by the module? If yes, move them to libexec. No?
Move them to bin. Change the mode appropriately.

mod_scgi.i386: E: non-executable-script
/usr/lib/python2.4/site-packages/scgi/test_passfd.py 0644

You should probably not bundle this. If you mind completely removing this, mark
it as %doc-umentation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.