[Bug 471754] Review Request: virtaal - Localization and translation editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471754





--- Comment #4 from Dwayne Bailey <dwayne at translate.org.za>  2008-12-06 10:21:00 EDT ---
Fabian -> thanks for the review.  I disappeared on holiday just before.  My
comments below.

(In reply to comment #3)
> Just some quick comments on your spec file.
> 
> - 'BuildRequires: python-devel' should be 'BuildRequires: python'
>   https://fedoraproject.org/wiki/Packaging/Python#BuildRequires

python-devel is still required, otherwise building fails.  I added python as a
build requires, although this is already pulled in by python-devel.

> - %{buildroot} and $RPM_BUILD_ROOT should not be mixed.

Fixed 

> - '--vendor="fedora" \' is obsolete for new packages.
>   see https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor

Fixed

> - remove '.fc9' in your %changelog section

Fixed

New SPEC: http://dwayne.fedorapeople.org/virtaal-0.2-2.spec
New SRPM: http://dwayne.fedorapeople.org/virtaal-0.2-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.