[Bug 474816] Review Request: perl-Text-FindIndent - heuristically determine the indent style

bugzilla at redhat.com bugzilla at redhat.com
Sat Dec 6 23:01:24 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474816


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-12-06 18:01:23 EDT ---
Not much to say about this one.

* source files match upstream.  sha256sum:
   89ad4545a3958331e999f54a9a5875271d398a0c4678b849e0d3ecb3c0a2ffa9  
   Text-FindIndent-0.03.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Text::FindIndent) = 0.03
   perl-Text-FindIndent = 0.03-1.fc11
  =
   perl >= 0:5.00503
   perl(:MODULE_COMPAT_5.10.0)
   perl(strict)
   perl(vars)

* %check is present and all tests pass:
   All tests successful.
   Files=2, Tests=35,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.05 cusr  0.00 
    csys =  0.06 CPU)

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list