[Bug 451405] Review Request: python-weberror - Web Error handling and exception catching middleware

bugzilla at redhat.com bugzilla at redhat.com
Sun Dec 7 04:38:17 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451405


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




--- Comment #10 from Jason Tibbitts <tibbs at math.uh.edu>  2008-12-06 23:38:15 EDT ---
As for the release weirdness, note that the spec in comment 7 and the spec
inside the src.rpm from comment 7 are not identical.

In any case, let me do a full review.

I might suggest that you expand the "WSGI" acronym in the description; I was
curious as to what SGI was up to until I looked it up.  I don't think it's a
big deal, though.

I do want to make sure that you're aware that this seems to bundle its own copy
of at least part of jquery, which might fall afoul of future javascript
packaging guidelines.

* source files match upstream.  sha256sum:
   0ab082270ceaf67de2761a521b1307b5869f790542fca8496d5fc029b62b1d0f  
   WebError-0.9.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   python-weberror = 0.9.1-1.fc11
  =
   python(abi) = 2.6
   python-pygments
   python-simplejson
   python-tempita
   python-webob

* %check is present and all tests pass:
   Ran 16 tests in 0.339s
   OK

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list