[Bug 456756] Review Request: alien - A program that converts between the rpm, dpkg, stampede slp, and slackware tgz

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456756


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #10 from Fabian Affolter <fabian at bernewireless.net>  2008-12-08 04:51:54 EDT ---
Just two remark

- Shouldn't 'Build: perl' be 'Requires:  perl(:MODULE_COMPAT_%(eval "`%{__perl}
-V:version`"; echo $version))' ? ->
https://fedoraproject.org/wiki/Packaging/Perl#Versioned_MODULE_COMPAT__Requires)

- You are mixing $RPM_BUILD_ROOT and %{buildroot}. ->
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.