[Bug 474768] Review Request: jpilot-backup - An enhanced backup plugin for J-Pilot

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474768





--- Comment #3 from Thorsten Leemhuis <fedora at leemhuis.info>  2008-12-08 09:43:23 EDT ---
(In reply to comment #1)
> Just some comments on your spec file

Agreed to most of them (and thanks for your help), with one note:

> - Remove the *.la files.  They should not be included.

Some apps require *.la files for plugins. Is that maybe the case here?

In reply to comment #2)
> - 'Release:  3' should be 'Release:  3%{dist}'

Not required, but makes things a whole lot easier


In addition (just some things from a quick look): 

- summary should not start with "A" or "An"

- I don't like the "enhanced" in the summary much, as that information is not
helpful at all for new users

- repeating the summary in the %description IMHO is wasting space 

- just wondering: "make install DESTDIR=$RPM_BUILD_ROOT" doesn't work instead
of  "make prefix=$RPM_BUILD_ROOT%{_prefix}"?

- would be nice to split the {build,}requires in multiple lines (one per line)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.