[Bug 458440] Review Request: bluemindo - Simple audio player in python/GTK

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458440


Florent le Coz <louizatakk at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(louizatakk at gmail. |
                   |com)                        |




--- Comment #6 from Florent le Coz <louizatakk at gmail.com>  2008-12-09 20:06:02 EDT ---
First of all : Really sorry for the delay... I was quite busy, and a bit lazy
too...
And thank you for the review :)

So, here is a new version:
SRPM: http://louizatakk.no-ip.org/fedora/bluemindo-0.2.1-2.fc10.src.rpm 
SPEC: http://louizatakk.no-ip.org/fedora/bluemindo.spec

(In reply to comment #2)
> (In reply to comment #0)
> > rpmlint reports 9 errors: "script-without-shebang", should I patch to correct
> > these errors ? (these shebang aren't needed at all)
> 
> You can remove the shebang in the spec file or make a patch whatever you like.
> https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Remove_shebang_from_files
Done, but it's a little "hackish" for this sort of thing, is it really
necessary ?
Now rpmlint only complains about the __init__.py missing the shebang, but the
software simply can NOT work when the __init__.py files aren't empty.

> 
> Just some quick comments on your spec file.
> 
> Macros
>  - You are using a lot of macros.  IMHO, you should consider to drop them. 
> Your spec file will be more readable.  Even you miss one (
> %{appdir}/locale/bluemindo.pot -> podir?) ;-)
Ok, I removed them

> 
> BuildRequires:
>  - Python packages should be sure to have: BuildRequires: python
>    https://fedoraproject.org/wiki/Packaging/Python
> 
Thanks, done

> %build section
>  - What is %{nil}? 
> 

Like None or NULL, it does nothing...
But now I use the %build section, I removed it

> Source0: http://www.codingteam.net/upload/77133a-bluemindo-0.2.1.tar.gz
>  - You can switch to 'Source0:
> http://www.codingteam.net/upload/77133a-%{name}-%{version}.tar.gz' this way you
> haven't to take care of this after a new release of the source.
Yeah, I usually do it, but I forgot... fixed.


> 
> %files
>  - You can add all %doc entries on one line %doc AUTHORS CHANGELOG... but that
> only cosmetical
Yeah, pretty neat, now :)
> 
> %changelog
>  - for correct changelog entries, take a look at
> https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

Yes, there was a little mistake.


Oh, and I added the handling of the language, I find my way to do it very
"hackish" (once again), I don't know if it's the way to do it, but it actually
works.

New review welcome :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.