[Bug 458254] Review Request: fedora-package-config-zypper - Repository configuration for zypper

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458254





--- Comment #4 from Lorenzo Villani <lvillani at binaryhelix.net>  2008-12-10 09:41:45 EDT ---
SPEC URL:
http://fedorapeople.org/gitweb?p=arbiter/public_git/rpm.git;a=blob_plain;f=system/fedora-package-config-zypper/fedora-package-config-zypper.spec;hb=HEAD

SRPM URL:
http://fedorapeople.org/~arbiter/srpm/fedora-package-config-zypper-10-1.fc10.src.rpm

(In reply to comment #3)
> Just some quick comments on your spec file
> 
> - Don't mix $RPM_BUILD_ROOT and %{buildroot}
>  
> https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

Done

> 
> - URL is not the upstream URL.  Why not pack the file together and make a
> proper release which is hosted on fedorahosted.org?
I put ZYpp url instead of fedoraproject.org, is that ok?

> 
> - &doc is empty.  Is it necessary?
> 
Removed %doc

> Zypper is not available for Fedora at the moment.  Does it make sense to add
> *.repo files without the tool to use them?
This review depends on the core zypp components, due to our recent move to rpm
4.6 upstream has to port it to that specific version before we can include it
in Fedora. It makes sense to me to have the review sitting around until they
fix the build issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.