[Bug 450442] Review Request: rubygem-tiddlywiki_cp - Copy tiddlers to files and vice versa

bugzilla at redhat.com bugzilla at redhat.com
Thu Dec 11 17:07:27 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450442


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




--- Comment #1 from Till Maas <opensource at till.name>  2008-12-11 12:07:25 EDT ---
It is easier to understand what you are writing about the rpmlint output, if
you also attach it:

rubygem-tiddlywiki_cp.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/tiddlywiki_cp-0.5.3/scripts/txt2html 0644

Don't you get this error?

rubygem-tiddlywiki_cp.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/tiddlywiki_cp-0.5.3/test/content/ignored#
rubygem-tiddlywiki_cp.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/tiddlywiki_cp-0.5.3/test/content/a
rubygem-tiddlywiki_cp.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/tiddlywiki_cp-0.5.3/test/content/d/CVS
rubygem-tiddlywiki_cp.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/tiddlywiki_cp-0.5.3/test/content/b
rubygem-tiddlywiki_cp.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/tiddlywiki_cp-0.5.3/test/content/a.div

My rpmbuild also complains, that some files are mentioned multiple times in
%files:

%{gemdir}/gems/%{gemname}-%{version}/
%doc %{geminstdir}/README.txt

The first path already includes the second one, because at the beginning of
the spec, %geminstdir is defined as follows:

%define geminstdir %{gemdir}/gems/%{gemname}-%{version}

Or in other words: 
%{gemdir}/gems/%{gemname}-%{version}/
can be directly written as %{geminstdir}/ in %files.

>From the Review Guidelines:
| - MUST: A package must not contain any duplicate files in the %files listing.

- Btw. the e-mail address in %changelog is probably only valid on your local
  machine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list