[Bug 472027] Review Request: onboard - Simple on-screen Keyboard

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472027





--- Comment #9 from Fabian Affolter <fabian at bernewireless.net>  2008-12-14 07:56:48 EDT ---
(In reply to comment #2)
> Suggestion:-
>    1) Good to modify onboard.desktop file line from 
> Categories=GNOME;GTK;Accessibility;X-GNOME-PersonalSettings;
> to
> Categories=GNOME;GTK;Utility;Accessibility;
> 
>    This will make sure we have all onboard/onscreen virtual keyboards in same
> category

fixed.  For now I'm OK with the usage of your modified files.  In the trunk of
onBoard are already .desktop files which will be shipped with the next release,
I guess.

>    2) This package built successfully by removing
>        BuildRequires:  python-setuptools-devel

This is needed for the generation of the egg.  It's mentioned in the guidelines

>        BuildRequires:  gettext

I will leave it in place because as soon I'm able to integrate the translations
it's needed.

>    3) I think you don't need Requires: gnome-python2 not sure about that
> though.

removed

Here are the new files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/onboard.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/onboard-0.91.2-3.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.