[Bug 474818] Review Request: perl-Class-XSAccessor - Generate fast XS accessors without runtime compilation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474818


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #8 from Parag AN(पराग) <panemade at gmail.com>  2008-12-15 08:15:03 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=999048
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
6cc5e214d9873f9205c2c49a1b7f3008  Class-XSAccessor-0.14.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=6, Tests=65,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.19 cusr  0.02
csys =  0.23 CPU)
+ Package perl-Class-XSAccessor-0.14-1.fc11 =>
  Provides: XSAccessor.so perl(Class::XSAccessor) = 0.14
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl >=
0:5.006 perl(Carp) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.