[Bug 476623] Review Request: perl-Test-NeedsDisplay - Ensure that tests needing a display have one

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 16 11:07:47 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476623


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2008-12-16 06:07:46 EDT ---

Review:
+ package builds in mock (rawhide i386).
koji Build => koji is down currently.
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
63967780b12820a668fed932812f9327  Test-NeedsDisplay-1.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=4, Tests=2,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.13 cusr  0.02
csys =  0.18 CPU)
+ Package perl-Test-NeedsDisplay-1.05-1.fc11
Provides:
 perl(Test::NeedsDisplay) = 1.05
Requires:
 perl >= 0:5.006
 perl(Config)
 perl(File::Spec)
 perl(strict)
 perl(vars)

Suggestions:
  Drop unnecessary BR:perl >= 1:5.6.0

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list