[Bug 476712] Package Review: lua-rex - Regular expression handling library for Lua

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476712


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(lkundrak at v3.sk)   |




--- Comment #4 from Lubomir Rintel <lkundrak at v3.sk>  2008-12-17 07:04:14 EDT ---
(In reply to comment #3)
> Should the .so files go in a -devel subpackage?

No. They are not meant for use by linker, lua interpreter looks for .so files
specifically.

I'm thinking whether it makes sense to ship the .2.4 files, but it's that just
because upstream does so. The .so files don't have a SONAME and are not used by
dynamic linker, just dlopened by lua.

> License seems good
> 
> Why isn't doc/ packaged in %doc ?

I just forgot. I'll be including it in new package I'll post shortly.

> Why aren't smp_flags used?

There's a comment. Or should I be more specific than just "doesn't work"?

> What is the purpose of the manual lrexlib Provides?  What will be Requiring
> that, other than the other auto-generated Provides:
> 
> rex_onig.so.2.4  
> rex_pcre.so.2.4  
> rex_posix.so.2.4  
> lua-rex = 2.4.0-1.fc11
> lua-rex(x86-32) = 2.4.0-1.fc11

That's an upstream name. While it is desirable to name this package lua-rex, to
denote it's a lua rex module there's a chance people will try to install it by
doing "yum install lrexlib". If I remember correctly this is a recommended
practice for perl modules, and I assumed it would be the same for lua.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.