[Bug 476926] Review Request: tcl-tclxml - XML parsing utilities for Tcl

bugzilla at redhat.com bugzilla at redhat.com
Thu Dec 18 07:45:16 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476926


Marcela Maslanova <mmaslano at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mmaslano at redhat.com




--- Comment #1 from Marcela Maslanova <mmaslano at redhat.com>  2008-12-18 02:45:14 EDT ---
OK source files match upstream: 
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field BSD matches the actual license.
OK license is open source-compatible.
OK latest version is being packaged.
OK BuildRequires are proper.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
tcl-tclxml.x86_64: E: explicit-lib-dependency tcllib
tcl-tclxml.x86_64: W: obsolete-not-provided tclxml-libxml2
tcl-tclxml.x86_64: W: obsolete-not-provided tclxml-expat
tcl-tclxml.x86_64: W: obsolete-not-provided tcldom-expat
tcl-tclxml.x86_64: W: obsolete-not-provided tcldom-libxml2
devel:
tcl-tclxml-devel.x86_64: W: no-documentation
tcl-tclxml-devel.x86_64: W: spurious-executable-perm
/usr/lib64/tcl8.5/tclxml-3.2/libTclxmlstub3.2.a
gui:
tcl-tclxml-gui.x86_64: W: no-documentation
OK final provides and requires look sane.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list