[Bug 475755] Review Request: devtodo - Manage a hierarchical, prioritised list of outstanding tasks, jobs, or just reminders.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475755


Patrick Monnerat <pm at datasphere.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pm at datasphere.ch




--- Comment #1 from Patrick Monnerat <pm at datasphere.ch>  2008-12-18 10:44:45 EDT ---
Some remarks:

rpmlint devtodo.spec:
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

rpmlint devtodo-0.1.20-1.src.rpm:
devtodo.src: W: summary-ended-with-dot Manage a hierarchical, prioritised list
of outstanding tasks, jobs, or just reminders.
devtodo.src: E: summary-too-long Manage a hierarchical, prioritised list of
outstanding tasks, jobs, or just reminders.
devtodo.src: W: no-version-in-last-changelog
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

--> Please shorten the summary and suppressed the final "."
--> You also have to version changelog comments.
--> Release should end with "%{?dist}"

rpmlint devtodo-0.1.20-1.i386.rpm
devtodo.i386: W: non-conffile-in-etc /etc/profile.d/scripts.tcsh
devtodo.i386: E: standard-dir-owned-by-package /etc/profile.d
devtodo.i386: W: non-conffile-in-etc /etc/profile.d/scripts.sh
devtodo.i386: W: summary-ended-with-dot Manage a hierarchical, prioritised list
of outstanding tasks, jobs, or just reminders.
devtodo.i386: E: summary-too-long Manage a hierarchical, prioritised list of
outstanding tasks, jobs, or just reminders.
devtodo.i386: W: no-version-in-last-changelog
devtodo.i386: W: conffile-without-noreplace-flag /etc/todorc
1 packages and 0 specfiles checked; 2 errors, 5 warnings.

--> /etc/profile.d is owned by package setup, so you should not mention "%dir
%{_sysconfdir}/profile.d" in you package files list.
--> Please use "%config(noreplace) for file %{_sysconfdir}/todorc, or explain
why you don't use it.
--> The name "scripts.sh" and "scripts.tcsh" are too "impersonal" in
system-wide directory %{_sysconfdir}/profile.d: i.e. change them to
"devtodo.sh" and "devtodo.csh".

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1006248

--> %doc:
 _ INSTALL should not be packaged.
 _ %{_mandir}/... should be outside of %doc
 _ %{_mandir}/... explicit names should be avoided since compression (thus name
extension) is achieved by the rpmbuild macros. Use "%{_mandir}/man1/*".

License: Should probably be GPLv2, not GPLv2+: GPL v2 license is contained in
 the tarball, but no source file (except those generated by the autotools)
menti
on it. I cannot find any note saying "GPL2 or later"...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.