[Bug 453839] Review Request: phatch - photo batch processor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453839





--- Comment #10 from Nicoleau Fabien <nicoleau.fabien at gmail.com>  2008-12-19 10:33:37 EDT ---
Thank you for taking this review.
Update :
Spec URL: http://nicoleau.fabien.free.fr/rpms/SPECS/phatch.spec
SRPM URL:
http://nicoleau.fabien.free.fr/rpms/srpms.fc10/phatch-0.1.6-2.fc10.src.rpm

Changelog :
- subpckage created for nautilus extension
- timestamp preserved for sed'ed file
- wxPython-devel removed from BuildRequires
- Source0 updated
- whole documentation included
- update-desktop-database and update-mime-database added
- egg-info properly builded
- python-devel buildrequries changed to python (whithout that, build uner
mock/koji failed)

Source0 is a "stable" URL. The url changed from far but I didn't have update it
in my SPEC.
I tried to use scrollkeeper but no additionnal documentation was generated, so
I removed it. 
I also contacted upstream about the software version (egg file generated
contains "0.1.5" instead of "0.1.6" and the "about" dialog display also "0.1.5"
instead of "0.1.6").

Package build on koji :  https://bugzilla.redhat.com/show_bug.cgi?id=453839
repmlint output :
[builder at FEDOBOX ~]$ rpmlint
/home/builder/rpmbuild/SRPMS/phatch-0.1.6-2.fc10.src.rpm
/home/builder/rpmbuild/RPMS/i386/phatch-0.1.6-2.fc10.i386.rpm
/home/builder/rpmbuild/RPMS/i386/phatch-nautilus-extension-0.1.6-2.fc10.i386.rpm
phatch.i386: E: no-binary
phatch-nautilus-extension.i386: W: no-documentation
phatch-nautilus-extension.i386: E: only-non-binary-in-usr-lib
3 packages and 0 specfiles checked; 2 errors, 1 warnings.
[builder at FEDOBOX ~]$

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.