[Bug 476471] Review Request: fedora-Linux_Security_Guide - A security guide for linux

bugzilla at redhat.com bugzilla at redhat.com
Mon Dec 22 08:58:10 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476471





--- Comment #4 from Fabian Affolter <fabian at bernewireless.net>  2008-12-22 03:58:09 EDT ---
- The spec file name and the SRPM name are different.
- Changelog entries are still missing.
  https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs
- URL should be https://fedorahosted.org/securityguide/
- Source0 should be point to the upstream source location, to the source
tarball to be more precise.
  Please refer to https://fedorahosted.org/web/faq, Section 'How can I publish
archive releases (tgz, zip, etc) for my project?'
- If there are no 'BuildRequires:' or 'Requires:' leave those entries away.
- Isn't this package 'BuildArch: noarch' ?
- The license should be only 'Open Publication'
  See https://fedoraproject.org/wiki/Licensing#Good_Licenses_2
- Your %file section seems to be unfinished 


I'm not able to rebuild your package on Fedora 9.

*ERROR: Brand fedora is not installed*
Either install fedora or change to a valid Brand.
Installed Brands: echo common
make: *** [pre] Error 1


The rpmlint output of the SRPM:

[fab at laptop024 SRPMS]$ rpmlint
fedora-Linux_Security_Guide-10-en-US-1.0-3.src.rpm 
fedora-Linux_Security_Guide-10-en-US.src: W: mixed-use-of-spaces-and-tabs
(spaces: line 3, tab: line 2)
fedora-Linux_Security_Guide-10-en-US.src: E: no-changelogname-tag
fedora-Linux_Security_Guide-10-en-US.src: W: invalid-license Open Publication
License
1 packages and 0 specfiles checked; 1 errors, 2 warnings.


For translations, take a look at
https://translate.fedoraproject.org/submit/maintainers/info

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list