[Bug 472060] Review Request: mumbles - growl like notification system for gnome

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 23 00:17:58 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472060


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |fedora at christoph-wickert.de




--- Comment #10 from Christoph Wickert <fedora at christoph-wickert.de>  2008-12-22 19:17:56 EDT ---
Does not build in rawhide, because rawhide has python-2.6, but your spec file
hardcodes the python version in the %files section:

  %{python_sitelib}/%{name}-%{version}-py2.5.egg-info
                                       ^^^
To make this more flexible replace with

  %{python_sitelib}/%{name}-%{version}-py%{python_version}.egg-info

and add

  %{!?python_version: %define python_version %(%{__python} -c "from
distutils.sysconfig import get_python_version; print get_python_version()")}

at the beginning of your spec.

Another small fix: desktop-file-install will complain that the icon in the
specfile is specified with file extension although it does not have an absolute
path. A little sed fix for the %prep section:

  # small fix to avoid warning from desktop-file-install
  sed -i 's!mumbles.png!mumbles!' bin/mumbles.desktop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list