[Bug 477990] Review Request: xfce4-settings - Settings Manager for Xfce

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477990


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Lubomir Rintel <lkundrak at v3.sk>  2008-12-27 09:04:35 EDT ---
(In reply to comment #0)
> Note: this package is part of the upcoming Xfce 4.6. 
> You will need:

Apart from the packages you enumerated that were found in xfce4-settings [1]
directory, I've also grabbed xfconf [2], since a couple of packages demanded
it.

[1] http://www.scrye.com/~kevin/fedora/xfce4-settings/
[2] http://www.scrye.com/~kevin/fedora/xfconf/

* RPMlint is silent and happy
* Spec file is mostly sane and legible
* Compiler flags are used appropriately
* Builds find in mock, with additional repository of xfce packages
* Requires, provides and filelists are sane
* License is correct

A few notes:

1.) Please don't do --vendor ""; in case upstream specifies vendor field, do
not reset it, otherwise set it to "fedora"
https://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation

2.) Please ensure the following is correct:
Build Configuration:
* Installation prefix:       /usr
* Debug Support:             minimum
* Libnotify support:         no
* Xcursor support:           yes
* Sounds settings support    no
* Libxklavier support:       no
Did you really mean to build w/o support for the above?

3.) The following line seems useless:
find $RPM_BUILD_ROOT -name '*.desktop' -ls
I guest it was forgotten there. Please remove it.

I don't think any of the above would warrant a review blocker:

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.