[Bug 457219] Review Request: python-twisted-web2 - Next generation Twisted Web Server Framework

Mon Dec 29 15:18:58 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=457219

--- Comment #16 from Michal Schmidt <mschmidt at redhat.com>  2008-12-29 10:18:55 EDT ---
Please fix the !?/?! confusion.

I suggest adjusting Summary and %description. Upstream no longer calls Web2 the
"next generation" framework, they now call it "experimental". According to
http://twistedmatrix.com/trac/wiki/TwistedWeb2 they are merging its
functionality into Twisted-Web. When they're done, Web2 will be obsoleted.

Everything else looks OK. Details:

# MUST: rpmlint must be run on every package. The output should be posted in
the review.
  python-twisted-web2.src: I: checking
  python-twisted-web2.x86_64: I: checking
  python-twisted-web2.x86_64: E: no-binary
  2 packages and 0 specfiles checked; 1 errors, 0 warnings.
OK. This error is expected here and should be ignored.

# MUST: The package must be named according to the Package Naming Guidelines .
OK.

# MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK.

# MUST: The package must meet the Packaging Guidelines .
OK.
Checked: Naming, Legal, No pre-built binaries, Spec legibility, Arch support,
Filesystem layout, Rpmlint, Changelogs, BuildRoot (it's not the most preferred
form, but it's one of the allowed ones, and RPM 4.6 ignores it anyway),
Requires, BuildRequires, Summary and description, Encoding, Documentation,
Debuginfo packages, Duplication of system libraries, Macros, Timestamps,
Scriptlets requirements, File and Directory Ownership, Conflicts, No External
Kernel Modules, No Files or Directories under /srv, Bundling of multiple
projects  
N/A: Compiler flags, Shared Libraries, Exclusion of Static Libraries, Beware of
Rpath, Configuration files, Initscripts, Desktop files, Handling Locale Files,
Parallel make, Conditional dependencies, Relocatable packages, Code Vs Content,
Users and Groups, Web Applications,

# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
OK. MIT license.

# MUST: The License field in the package spec file must match the actual
license.
OK.

# MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK.

# MUST: The spec file must be written in American English.
OK.

# MUST: The spec file for the package MUST be legible.
OK.

# MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK. 4a03e62453037b009ee5f0e1396be792249b9e2f  TwistedWeb2-8.1.0.tar.bz2

# MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK. Builds in Koji on all archs:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1024731

# MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
N/A.

# MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK.

# MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
N/A.

# MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
N/A.

# MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package.
N/A.

# MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
OK.

# MUST: A package must not contain any duplicate files in the %files listing.
OK.

# MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK.

# MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} ( or $RPM_BUILD_ROOT ).
OK.

# MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines .
OK.

# MUST: The package must contain code, or permissable content. This is
described in detail in the code vs. content section of Packaging Guidelines .
OK.

# MUST: Large documentation files should go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity)
OK. The main package includes documentation files, the documentation is not too
large, split is not necessary.

# MUST: If a package includes something as %doc, it must not affect the runtime
of the application.
OK.

# MUST: Header files must be in a -devel package.
N/A.

# MUST: Static libraries must be in a -static package.
N/A.

# MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
N/A.

# MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
N/A.

# MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency.
N/A.

# MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
OK.

# MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
N/A.

# MUST: Packages must not own files or directories already owned by other
packages.
OK.

# MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
( or $RPM_BUILD_ROOT ).
OK.

# MUST: All filenames in rpm packages must be valid UTF-8.
OK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.