[Bug 226552] Merge Review: xdelta

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226552


manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review?




--- Comment #1 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-12-30 18:48:26 EDT ---
BuildRoot ( %{_tmppath}/%{name}-root ) is not one of the values accepted in the
packaging guidelines.

License seems to be GPLv2+ (not GPLv2) and the file COPYING should be included
in %docs. I suggest to also add AUTHORS.

Source0 should be
http://xdelta.googlecode.com/files/xdelta-1.1.4.tar.gz
Latest version is xdelta3.0u
(http://xdelta.googlecode.com/files/xdelta3.0u.tar.gz), I had to dig below
"deprecated" to locate the source0 URL for 1.1.4.

Current URL is http://xdelta.org/.

There are duplicate BRs: pkgconfig (by glib2-devel), automake (by libtool),
autoconf (by libtool). however this is mostly cosmetic .

rpmlint is unhappy, most notably is the rpath signaled in the binary rpm:
Source RPM:
xdelta.src:223: W: macro-in-%changelog doc
xdelta.src:225: W: macro-in-%changelog defattr
xdelta.src:235: W: macro-in-%changelog defattr
xdelta.src:240: W: macro-in-%changelog setup
xdelta.src:250: W: macro-in-%changelog doc
xdelta.src:251: W: macro-in-%changelog post
xdelta.src:254: W: macro-in-%changelog defattr
xdelta.src: W: summary-ended-with-dot A binary file delta generator and an RCS
replacement library.
1 packages and 0 specfiles checked; 0 errors, 8 warnings.

rpmlint of xdelta-debuginfo:
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/generic.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/getopt.h
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/sha.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/xdeltapriv.h
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/md5c.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/library.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/simple.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/edsio_edsio.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/edsio_edsio.h
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/default.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/xdmain.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/partime.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/base64.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/partime.h
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/edsio.h
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/xdapply.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/maketime.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/edsio.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/libedsio/fh.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/xd_edsio.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/xdelta.c
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/xdelta.h
xdelta-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xdelta-1.1.4/xd_edsio.h
1 packages and 0 specfiles checked; 0 errors, 23 warnings.


rpmlint of xdelta:
xdelta.x86_64: W: spurious-executable-perm
/usr/share/doc/xdelta-1.1.4/xdelta.magic
xdelta.x86_64: W: spurious-executable-perm /usr/share/doc/xdelta-1.1.4/NEWS
xdelta.x86_64: W: spurious-executable-perm /usr/share/doc/xdelta-1.1.4/README
xdelta.x86_64: W: summary-ended-with-dot A binary file delta generator and an
RCS replacement library.
xdelta.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/xdelta ['/usr/lib64']
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

rpmlint of xdelta-devel:
xdelta-devel.x86_64: W: no-documentation
xdelta-devel.x86_64: W: summary-ended-with-dot Static library and header files
for Xdelta development.
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

I also notice that the devel package includes two static libs
(/usr/lib64/libedsio.a, /usr/lib64/libxdelta.a). If including them is really
intended, according to
https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries
a separate xdelta-static package should be created for them.

According to https://fedoraproject.org/wiki/Packaging/ReviewGuidelines, the
xdelta-devel package should require pkgconfig, although I guess that the
/usr/bin/pkg-config included automatically by rpmbuild is enough.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.