[Bug 473718] Review Request: perl-Directory-Scratch-Structured - Creates temporary files and directories from a structured description

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473718


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Parag AN(पराग) <panemade at gmail.com>  2008-12-31 00:31:56 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1026687
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
ef6155cc8a9723e0e9614508aa1c592d  Directory-Scratch-Structured-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=4, Tests=18,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.50 cusr  0.04
csys =  0.56 CPU)
+ Package perl-Directory-Scratch-Structured-0.04-1.fc11 =>
Provides: perl(Directory::Scratch::Structured) = 0.04
Requires: perl(Carp) perl(Directory::Scratch) perl(English) perl(Readonly)
perl(Sub::Exporter) perl(Sub::Install) perl(strict) perl(vars) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.