[Bug 475000] Review Request: cmconvert - CacheMate import file converter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475000





--- Comment #6 from Patrick C. F. Ernzer <pcfe at redhat.com>  2008-12-31 09:45:56 EDT ---
(In reply to comment #5)
> rpmlint output 
apologies for forgetting to run that. It now reports 0 errors, 0 warnings after
the changes below.

> cmconvert.src:38: E: files-attr-not-set
[...]
fixed.

> - Is 'mkdir -p -m 0755 %{buildroot}/usr' really needed?
You're right. It is not needed. Removed.

> - Use make install DESTDIR=%{buildroot} INSTALL="install -p" to preserve the
> timestamps instead of make install DESTDIR=%{buildroot}
done

> - There is no need to pack the file 'INSTALL' because it contains only generic
> information which are not useful when installed from RPM
agreed, removed.

cmconvert-1.9.5-4.fc10.src.rpm  and revised spec file uploaded.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.