[Bug 433161] Review Request: cwdaemon - Morse daemon for the parallel or serial port

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwdaemon - Morse daemon for the parallel or serial port


https://bugzilla.redhat.com/show_bug.cgi?id=433161





------- Additional Comments From tmz at pobox.com  2008-02-18 00:45 EST -------
Curse bugzilla.  It just ate a ton of comments I'd made. :(

Mamoru is right about the link being a bad idea.  Sorry about that.  It might be
best to just patch the man page.  Maybe I'm being pedantic, but I hate it when
man pages and other docs point me to things that don't exist.

I'm still unclear on the point of the devel package.  I don't see how any other
apps are expected to make use of this single c source file.  Without knowing how
apps use it, I don't see any reason to include it.  Can you ask upstream or find
some apps that use it as is?  I imagine that the intent is to have it compiled
to be of use.

I am also curious how the daemon is to be used, whether it's a long running
daemon, run from xinetd, or something kicked off from the command line as
needed?  Bob, you mentioned in #fedora-devel that other apps would start it on
demand.  Can you elaborate a bit on that and perhaps point to some examples? 
(Please pardon my ignorance as a non-ham. :)

Looking at the README, it directs users to see "the examples in the schematics
directory."  But that refers to a dir in the tarball.  The files it's referring
to are installed in %{_datadir}/%{name}.  It seems to me that those examples
belong in %docdir instead (and the README updated accordingly so readers can
find the files easily).

That leaves cwdaemon.png and two shell scripts in %{_datadir}/%{name}
(cwsetup.sh and cwtest.sh).  The png could also be put into %docdir I believe
(it's not used for anything, is it?).  Are either of the shell scripts needed if
the rpm does the setup correctly?  cwsetup looks mostly useless for the package.
 cwtest.sh may be of use.  It seems that these script, if needed, should be
installed somewhere in $PATH.  cwtest.sh requires nc as well.

One other small thing, it's better to use %{_mandir}/man8/%{name}.8.gz for the
manpage instead of %{_datadir}/man.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.