[Bug 431047] Review Request: latencytop - System latency monitor

bugzilla at redhat.com bugzilla at redhat.com
Mon Feb 4 12:29:00 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





------- Additional Comments From panemade at gmail.com  2008-02-04 07:29 EST -------
(In reply to comment #10)
> re 1) We must have a misunderstanding about what whitespace you meant. I thought
> you referred to the extra line. Maybe you wanted me to drop the second hunk of
> the patch completely?

Yes. I mean following lines from patch to be removed
=============================================================================
 #
 # The w in -lncursesw is not a typo; it is the wide-character version
@@ -10,8 +10,7 @@ LDF = -Wl,--as-needed `pkg-config --libs
 # libncursesw5-dev package.
 #
 latencytop: latencytop.o display.o latencytop.h translate.o Makefile
-       gcc $(CFLAGS) latencytop.o display.o translate.o $(LDF)-o latencytop
-
+       gcc $(CFLAGS) latencytop.o display.o translate.o $(LDF) -o latencytop

 clean:
        rm -f *~ latencytop DEADJOE *.o
=========================================================================      
                                         
> 
> re 2 and 3) I agree it would be nice if upstream provided a README. I already
> asked for one when I was asking for the COPYING file. We'll see if a new
> upstream version adds them.
  Thanks.

> 
> 
> I can see Rawhide has kernel-2.6.24-9 currently. This kernel does not have
> LATENCYTOP support yet. The patch was merged upstream after the release of
> 2.6.24 in git commit 9745512ce... "sched: latencytop support".
> So you'd need to compile the kernel from the current git tree. Make sure you
> have CONFIG_LATENCYTOP enabled. After boot, start the measurement with:
> echo 1 > /proc/sys/kernel/latencytop
> Then you can run latencytop and see the output similar to the screenshot at
> http://www.latencytop.org/ .

 Hope to see our kernels will get compiled with CONFIG_LATENCYTOP enabled.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list