[Bug 431829] Review Request: thaifonts-scalable - Thai TrueType fonts
bugzilla at redhat.com
bugzilla at redhat.com
Fri Feb 8 04:10:09 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: thaifonts-scalable - Thai TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=431829
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade at gmail.com 2008-02-07 23:10 EST -------
+ is OK
- is Needs work
Review:
+ package builds in mock.
koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=402237
- rpmlint is NOT silent for SRPM and for RPM.
thaifonts-scalable.noarch: W: conffile-without-noreplace-flag
/etc/fonts/conf.avail/90-ttf-thai-tlwg-synthetic.conf
==>%config(noreplace) /etc/fonts/conf.avail/90-ttf-thai-tlwg-synthetic.conf
+ source files match upstream url
9dbeef8d508d199cafb69152cf9a762d thaifonts-scalable-0.4.9.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ fonts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
SHOULD:
1) you can write only rm also instead to write /bin/rm
2) your make install command should be
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list