[Bug 283081] Review Request: condor - Batch system for High Throughput Computing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: condor - Batch system for High Throughput Computing


https://bugzilla.redhat.com/show_bug.cgi?id=283081





------- Additional Comments From wolfy at nobugconsulting.ro  2008-02-08 19:24 EST -------
First of all. let me say, as a former LSF suer, that I am more then happy to see
this program finally arriving in our land. Kudos!

Second, a couple of comments
- please add a note before the Source0 tag, explaining that upstream explicitly
prohibits direct download, hence the missing full URL in this field.
For verification, one can provide the required personal info data at
http://parrot.cs.wisc.edu/v7.0.license.html and download the sources from
http://www.cs.wisc.edu/condor/cgi-bin/downloads/download.pl/v7.0#7.0.0-source-code
- there is no need to create a "patch" in order to add the init.d script. Just
provide it as Source1 and use it as such (not that what you have done is not
correct; it's just unnecessary complicated)
- the build log says:
checking for javac... no
configure: WARNING: javac not found
checking for jar... no
configure: WARNING: jar not found
Would condor be happier with icedtea / gcj as BR ?
-there is a "checking for zlib... no" line in the build log; would a BR
zlib-devel be nbeneficial ?
- parallel compiling seems to be disabled (and commented in the spec). Is it
still intended ?
- rpmlint says
condor.x86_64: W: service-default-enabled /etc/rc.d/init.d/condor
We usually require services to not be enabled by default


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.