[Bug 428798] Review Request: OmegaT - Computer Aid Translation tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OmegaT - Computer Aid Translation tool


https://bugzilla.redhat.com/show_bug.cgi?id=428798





------- Additional Comments From ismael at olea.org  2008-02-11 08:00 EST -------
(In reply to comment #3)
> For 1.7.3-4:
> 
> * Spec file name
>   - We request that the name of the spec file must coincide
>     with the name of rpm.


done 

> * About Source1:
>   - Please write the full URL for Source1.
>     Otherwise please write how you gained Source1 as comments
>     in the spec file

I've used the original one inside the sources... done?

> * Pre-rebuilt binaries
>   - To make it sure that omegat is built from all free and
>     legally-compatible sources, please remove all pre-rebuilt
>     binaries (like *.jar) first at %prep like:
> ---------------------------------------------------------
> %prep
> %setup -q -c -n %{name}-%{version}
> find . -name \*.jar -exec rm {} . \;
> ----------------------------------------------------------

ups. Seems this is an stopping bug for me. I should investigate for fixing this :-/

> * Icon directory
>   - Icon must be installed not under %_iconsdir (/usr/share/icons)
>     but under %{_datadir}/pixmaps

as now is not using the previos icon, IMHO this is done too. 

> * Empty scriptlets
>   - Please remove empty %post/%postun

done.


Spec URL: http://olea.org/tmp/OmegaT.spec
SRPM URL: http://olea.org/paquetes-rpm/OmegaT-1.7.3-5olea.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.