[Bug 432033] Review Request: crystalspace - Crystal Space a free 3D engine
bugzilla at redhat.com
bugzilla at redhat.com
Thu Feb 14 07:07:48 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: crystalspace - Crystal Space a free 3D engine
https://bugzilla.redhat.com/show_bug.cgi?id=432033
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2008-02-14 02:07 EST -------
For 1.2-2:
A. spec file issue
* scriptlet output
- I guess that (although I could not find where it is written)
Fedora requests that scriptlet output must be quiet.
For now -utils %post scriptlets shows a lot of output messages.
If you want to keep these messages IMO these should be redirected
to some log file.
* Directory ownership issue
- My directory check shows (I have not installed -doc subpackage)
----------------------------------------------------------------
[tasaka1 at localhost crystalspace]$ grep package DIR-check.log | grep any
/usr/share/doc/crystalspace-1.2/LICENSE crystalspace-1.2-2.1.fc9
file /usr/share/doc/crystalspace-1.2 is not owned by any package
/usr/share/doc/crystalspace-1.2/README crystalspace-1.2-2.1.fc9
file /usr/share/doc/crystalspace-1.2 is not owned by any package
/usr/share/doc/crystalspace-1.2/history.old crystalspace-1.2-2.1.fc9
file /usr/share/doc/crystalspace-1.2 is not owned by any package
/usr/share/doc/crystalspace-1.2/history.txt crystalspace-1.2-2.1.fc9
file /usr/share/doc/crystalspace-1.2 is not owned by any package
/usr/share/doc/crystalspace-1.2/history_1.2.txt crystalspace-1.2-2.1.fc9
file /usr/share/doc/crystalspace-1.2 is not owned by any package
----------------------------------------------------------------
* Multilib issue
- I don't know how we should deal with multilib issue (no, I REALLY
don't know!!), however
at least %_bindir/cs-config-1.2 causes multilib conflict.
----------------------------------------------------------------
[tasaka1 at localhost bin]$ diff -u /usr/bin/cs-config-1.2 ./cs-config-1.2
--- /usr/bin/cs-config-1.2 2008-02-14 13:47:02.000000000 +0900
+++ ./cs-config-1.2 2008-02-14 13:41:13.000000000 +0900
@@ -26,7 +26,7 @@
do
prefix="${p}"
exec_prefix="${prefix}"
- makeout="./out/linuxx86/debug"
+ makeout="./out/linux/debug"
version="1.2"
longversion="crystalspace 1.2"
newincdir=""
@@ -92,7 +92,7 @@
case $1 in
-lcrystalspace-1.2) DEPS=" -lpthread -lpthread -lz" ;;
-lcrystalspace_opengl-1.2) DEPS=" -lcrystalspace-1.2 -lGL -lXext -lX11
-lX11 -lXext -lpthread -lm" ;;
- -lcrystalspace_python-1.2) DEPS=" -lcrystalspace-1.2
-L/usr/lib/python2.5 -lpython2.5 -lpthread -ldl -lutil -lm -lpthread" ;;
+ -lcrystalspace_python-1.2) DEPS=" -lcrystalspace-1.2
-L/usr/lib64/python2.5 -lpython2.5 -lpthread -ldl -lutil -lm -lpthread" ;;
-lcrystalspace_staticplugins-1.2) DEPS="" ;;
*)
-----------------------------------------------------------------
Someone says that on -devel subpackage multilib confilct must be
avoided.
* Dependency for -devel subpackage
- Please check the dependency for -devel subpackage.
Example:
- From /usr/include/crystalspace-1.2/csplugincommon/opengl/glcommon2d.h :
-----------------------------------------------------------------
26 #if defined(CS_OPENGL_PATH)
27 #include CS_HEADER_GLOBAL(CS_OPENGL_PATH,gl.h)
28 #else
29 #include <GL/gl.h>
30 #endif
-----------------------------------------------------------------
- /usr/include/crystalspace-1.2/ivideo/wxwin.h has #include <wx/wx.h>
- And some others.
? Timestamps
- This rpm installs many "non-built" files and keeping timestamps on
them are generally desirable. Would you try to keep timestamps on
installed files as much as possible?
(usually adding INSTALL="install -p" works, at least on recent
autotool-based Makefiles)
!!
For license issues, I will check it later (as the tarball contains more than
10000 files, which is the largest number I have ever reviewed)
!!
Again currently crystalspace does not build due to missing dep for hal :(
http://koji.fedoraproject.org/koji/taskinfo?taskID=425708
Simply rebuilding hal against new libsmbios seems good
http://koji.fedoraproject.org/koji/taskinfo?taskID=425729
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list