[Bug 432033] Review Request: crystalspace - Crystal Space a free 3D engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: crystalspace - Crystal Space a free 3D engine


https://bugzilla.redhat.com/show_bug.cgi?id=432033





------- Additional Comments From j.w.r.degoede at hhs.nl  2008-02-14 11:07 EST -------
(In reply to comment #7)
> For 1.2-2:
> 
> A. spec file issue
> * scriptlet output
>   - I guess that (although I could not find where it is written)
>     Fedora requests that scriptlet output must be quiet.
> 
>     For now -utils %post scriptlets shows a lot of output messages.
>     If you want to keep these messages IMO these should be redirected
>     to some log file.
> 

I didn't silence this to check it went ok during development, silenced now.

> * Directory ownership issue
>   - My directory check shows (I have not installed -doc subpackage)

Fixed


> * Multilib issue
>   - I don't know how we should deal with multilib issue (no, I REALLY
>     don't know!!), however
>     at least %_bindir/cs-config-1.2 causes multilib conflict.

Fixed


> * Dependency for -devel subpackage
>   - Please check the dependency for -devel subpackage.
>     Example:
>     - From /usr/include/crystalspace-1.2/csplugincommon/opengl/glcommon2d.h :
> -----------------------------------------------------------------
>     26  #if defined(CS_OPENGL_PATH)
>     27  #include CS_HEADER_GLOBAL(CS_OPENGL_PATH,gl.h)
>     28  #else
>     29  #include <GL/gl.h>
>     30  #endif
> -----------------------------------------------------------------
>     - /usr/include/crystalspace-1.2/ivideo/wxwin.h has #include <wx/wx.h>

Hmm, thats optional better to not frag in wx for people who use crystalspace
without wx.

Otherwise Fixed.

> ? Timestamps
>   - This rpm installs many "non-built" files and keeping timestamps on
>     them are generally desirable. Would you try to keep timestamps on
>     installed files as much as possible?
>     (usually adding INSTALL="install -p" works, at least on recent
>      autotool-based Makefiles)
> 

This does not use regular makefiles but jam, which I've been fighting all the
way to stop it from using custom CFLAGS, so I see no sane way to fix this.

New version:
Spec URL: http://people.atrpms.net/~hdegoede/crystalspace.spec
SRPM URL: http://people.atrpms.net/~hdegoede/crystalspace-1.2-3.fc9.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.