[Bug 433110] Review Request: python-tidy - Python wrapper for tidy, from the HTML tidy project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-tidy -  Python wrapper for tidy, from the HTML tidy project


https://bugzilla.redhat.com/show_bug.cgi?id=433110





------- Additional Comments From terjeros at phys.ntnu.no  2008-02-17 05:31 EST -------
(In reply to comment #1)
> BLOCKER: There is a mix of licenses for source package. You chosen wrong license
> for this package. Please, be careful when setting package license tags.

Fixed.
 
> BLOCKER: Package does not match package-naming-guidelines. Your package is named
> python-tidy and upstream package uTidylib. I see, that you are using just one
> part from this source, but I don't know, if we can mix that this way.

The name is correct (as I read this, make most sense too:

 http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-8756a3bce652c376d7ba3908461b638784b6952d
 
> BLOCKER: python-tidy.noarch: E: explicit-lib-dependency libtidy
> Add version info for libtidy requirement.

Fixed.

> Other comments:
> I think a better group for this package is Development/Languages .

php-tidy is using that, ok.

> Add version for python-devel. uTidylib requires python>=2.3

fixed

> This code is not required:
> %{python_sitelib}/tidy
> %if 0%{?fedora} >= 9
> %{python_sitelib}/%{oname}-%{version}-py%{pyver}.egg-info
> 
> You can use %{python_sitelib}/*

Both are valid, %if is safer when things changes, but ...
 
> As I don't know, what to do with this license mix, I can't approve you package
> now. If you can give me a link to more information.
> 
> You can ask author to remove path.py from this package and rename it's package
> as you need. Otherwise you need to fix these problems.

See the fix, it's normal to have several licenses on a package.


spec: http://terjeros.fedorapeople.org/python-tidy/python-tidy.spec
srpm: http://terjeros.fedorapeople.org/python-tidy/python-tidy-0.2-2.src.rpm





-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.