[Bug 431188] Review Request: minbar - Athan call and prayer times notification software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: minbar - Athan call and prayer times notification software


https://bugzilla.redhat.com/show_bug.cgi?id=431188





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-17 09:08 EST -------
For 0.2.1-3:

* Scriptlets
  - Scriptlets for GConf are not right. (also scriptlets for %pre
    is needed). Please check the subsection "GConf" of
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
  - Also the scriptlets for GTK icon cache are not right.
    Please check the same wiki page.

* Timestamp
  - To keep timestamps on installed files, I recommend to use
---------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
---------------------------------------------------------------
    This method usually works for recent autotool-based Makefiles.

* Desktop file
  - Why is the category 'Utility' listed twice?

* Documents
  - Usually the file "INSTALL" is for people who want to build and install
    softwares by themselves and is not needed for people using rpm system.
  - Files under %_mandir are automatically marked as %doc.

* macros
  - Please use macros correctly. For example /usr/bin must be %{_bindir}.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.