[Bug 431381] Review Request: unicap - Library to access different kinds of (video) capture devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unicap - Library to access different kinds of (video) capture devices


https://bugzilla.redhat.com/show_bug.cgi?id=431381


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-02-18 00:13 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=434209
+ rpmlint is silent for SRPM
- rpmlint is NOT silent for RPM.
unicap-devel.i386: W: dangling-relative-symlink /usr/lib/unicap2/cpi/libv4l2.so
libv4l2.so.0.0.0
unicap-devel.i386: W: dangling-relative-symlink /usr/lib/unicap2/cpi/libdcam.so
libdcam.so.0.0.0
unicap-devel.i386: W: dangling-relative-symlink /usr/lib/unicap2/cpi/libv4l.so
libv4l.so.0.0.0
unicap-devel.i386: W: dangling-relative-symlink
/usr/lib/unicap2/cpi/libvid21394.so libvid21394.so.0.0.0
unicap-devel.i386: E: only-non-binary-in-usr-lib
==> ok to accpet here.
+ source files match upstream.
0ab0a533f5c1ff3a24853d2564ffb14f  unicap-0.2.19.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ libucil.pc, libunicap.pc, libunicapgtk.pc files present.
+ -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig scriptlets are used.
+ Package unicap-0.2.19-3.fc9 ->
  Provides: libdcam.so.0 libucil.so.2 libunicap.so.2 libunicapgtk.so.2
libv4l.so.0 libv4l2.so.0 libvid21394.so.0
  Requires: libXext.so.6 libXv.so.1 libasound.so.2 libasound.so.2(ALSA_0.9)
libasound.so.2(ALSA_0.9.0rc4) libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcairo.so.2 libdcam.so.0
libdl.so.2 libdl.so.2(GLIBC_2.0) libdl.so.2(GLIBC_2.1) libgcc_s.so.1
libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_3.3.1) libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0
libgtk-x11-2.0.so.0 libm.so.6 libm.so.6(GLIBC_2.0) libogg.so.0 libpango-1.0.so.0
libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpthread.so.0
libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.1) libpthread.so.0(GLIBC_2.2)
libraw1394.so.8 librt.so.1 libtheora.so.0 libtheora.so.0(libtheora.so.1.0)
libucil.so.2 libunicap.so.2 libunicapgtk.so.2 libv4l.so.0 libv4l2.so.0
libvid21394.so.0 libvorbis.so.0 libvorbisenc.so.2 rtld(GNU_HASH)
+ Package unicap-devel-0.2.19-3.fc9 ->
  Requires: libdcam.so.0 libucil.so.2 libunicap.so.2 libunicapgtk.so.2
libv4l.so.0 libv4l2.so.0 libvid21394.so.0
+ Not a GUI app.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.