[Bug 239936] Review Request: oyranos - The Oyranos Colour Management System (CMS)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: oyranos - The Oyranos Colour Management System (CMS)


https://bugzilla.redhat.com/show_bug.cgi?id=239936





------- Additional Comments From pertusus at free.fr  2008-02-20 11:10 EST -------
(In reply to comment #22)

> So to sum-up (and I will need a reviewer advice for this). 
> Since some profiles may still problematic. I would rip off all icc profiles from
> oyranos and provides each profiles as a separate requirement for oyranos.
> 
> I would package them as:
> color-icc-profiles-cineon GPL/BSD ?
> color-icc-profiles-lcmsLAB Public Domain
> color-icc-profiles-sRGB 
> color-icc-profiles-PhotoGamutRGB (tell about Creatives Commons but not strong in
> deutch).
> colot-icc-profiles-LStarRGB (License need to be clarified but at least
> specifications are here for recreate them).

Why don't you package the profiles that are acceptable in fedora
in oyranos itself? Because they may be needed by other applications?
Because they have separate upstreams?

> Thoses profiles might be acceptables for Fedora. and as more profiles are
> present, they migh be added to a virtual provides,like
> color-icc-profiles-all
> I don't know if oyranos should Requires all profiles, but at least it can
> requires some, so it will work without complain at runtime.

It should certainly requires all the profiles that can be shipped in 
fedora.

> For the oyranos-monitor-nvidia: I will split off from the main package, and I
> will rename oyranos-monitor to oyranos-monitor-main, so when
> oyranos-monitor-nvidia will be installed, it will be used instead of the main
> oyranos-monitor (using alternatives).

That seems quite complicated. In any case a documentation, even minimal,
of oyranos-monitor-nvidia and oyranos-monitor is missing.

On the same subject, the  oyranos-config-fltk man page should be in 
the main package.

> About oyranos_version.h, i will rip out OY_SRCDIR and OY_SRC_LOCALEDIR and keep
> the timestramps from a reference file. (I wonder if this file should be used
> anyway).

It is not clear, indeed. It is a bit dubious to have all these 
symbols defined in the API. The API should be platform independent 
and it is clearly not the case here. There should be no file
name separator in the API, for example.



There are 2 rpmlint warnings relevant for -devel:
oyranos-devel.i386: E: zero-length
/usr/share/doc/oyranos-devel-0.1.7/html/structoyComp__s____coll__graph.map

This one is a bit strange, maybe doxygen is doing wrong things with maps
since there is a reference in the html to oyComp__s____coll__map

oyranos-devel.i386: W: file-not-utf8 /usr/share/doc/oyranos-devel-0.1.7/ChangeLog


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.