[Bug 433187] Review Request: boinc-client - A platform for distributed computing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boinc-client - A platform for distributed computing
Alias: boinc-client-review

https://bugzilla.redhat.com/show_bug.cgi?id=433187


mmahut at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|boinc-client-request        |boinc-client-review




------- Additional Comments From mmahut at redhat.com  2008-02-20 11:51 EST -------
Additional issues:

-- rpmlint output

   - boinc-client.i386: W: spurious-executable-perm
/usr/share/doc/boinc-client-5.10.40/checkin_notes 
   - boinc-client.i386: W: spurious-executable-perm
/usr/share/doc/boinc-client-5.10.40/checkin_notes_2006
    \- no reason to have executable documentation :)

   - boinc-client.i386: W: file-not-utf8
/usr/share/doc/boinc-client-5.10.40/checkin_notes_2005
   - boinc-client.i386: W: file-not-utf8
/usr/share/doc/boinc-client-5.10.40/checkin_notes_2004
    \- these files are not in utf8, use iconv in the spec file to convert

   - boinc-client.i386: W: bogus-variable-use-in-%pre $RPM_BUILD_ROOT
    \- do not use $RPM_BUILD_ROOT in %pre environment

   - boinc-client.i386: W: service-default-enabled /etc/rc.d/init.d/boinc-client
    \- it's not recommenced to have service enabled by default, user should
decide if he wants to enable it or not (imho)

   - boinc-client.i386: E: missing-mandatory-lsb-keyword Short-Description in
/etc/rc.d/init.d/boinc-client
   - boinc-client.i386: W: service-default-enabled /etc/rc.d/init.d/boinc-client
   - boinc-client.i386: W: no-reload-entry /etc/rc.d/init.d/boinc-client
   - boinc-client.i386: E: subsys-not-used /etc/rc.d/init.d/boinc-client
    \- http://fedoraproject.org/wiki/PackagingDrafts/SysVInitScript draft only
but it can help to resolve it


-- sources contains .svn directories 
   \- use svn export instead of svn checkout

-- translations are a good idea, but it's more elegant to translate it via
specspo once the spec file is imported
   \- http://translate.fedoraproject.org/module/specspo

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.