[Bug 433253] Review Request: dotconf - Required for speech dispatcher on OLPC XO

bugzilla at redhat.com bugzilla at redhat.com
Sun Feb 24 14:07:22 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dotconf - Required for speech dispatcher on OLPC XO


https://bugzilla.redhat.com/show_bug.cgi?id=433253





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-24 09:07 EST -------
For 1.0.13-4:

* Source tarball
  - The tarball in your srpm does not coincide with what
    is written as %Source:
----------------------------------------------------------
-rw------- 1 tasaka1 tasaka1 197993 2006-01-27 23:03 dotconf-1.0.13.tar.gz
-rw-rw-r-- 1 tasaka1 tasaka1 200442 2008-02-23 12:58
dotconf-1.0.13-4.fc7/dotconf-1.0.13.tar.gz
----------------------------------------------------------

* rpmlint
  Please check your rpms by rpmlint again?
----------------------------------------------------------
dotconf.src: W: summary-not-capitalized dot.conf
dotconf.src: E: description-line-too-long dotconf is a configuration file
parser. These libraries are used by many applications to handle configuration files.
dotconf.i386: W: file-not-utf8 /usr/share/doc/dotconf-1.0.13/AUTHORS
dotconf.i386: W: summary-not-capitalized dot.conf
dotconf.i386: E: description-line-too-long dotconf is a configuration file
parser. These libraries are used by many applications to handle configuration files.
dotconf.i386: W: incoherent-version-in-changelog 1.0,13.4 1.0.13-4.fc9
----------------------------------------------------------
  Summary:
  - Summary must begin with capital letter.
    Also, please change the Summary "dot.conf". This Summary description
    is not useful.

  - description-line-too-long:
----------------------------------------------------------
$ rpmlint -I description-line-too-long
description-line-too-long :
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.
----------------------------------------------------------

   - AUTHORS file is not encoded with UTF-8. Please change the
     encoding to UTF-8.

   - The EVR (epoch-version-release) in %changelog is not right.
----------------------------------------------------------
* Sat Feb 23 2008 Assim Deodia<assim.deodia at gmail.com> 1.0.13-4
- Applied patch macro

* Sat Feb 23 2008 Assim Deodia<assim.deodia at gmail.com> 1.0.13-3
----------------------------------------------------------
     Also please insert one line between each %changelog entry.
     This is useful for Fedora's CVS system.

Then, as this is NEEDSPONSOR ticket:

-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora Extras package review requests which are waiting for someone to
review can be checked on:
https://bugzilla.redhat.com/bugzilla/buglist.cgi?cmdtype=runnamed&namedcmd=mtasaka-review-noone
NOTE: FE-NEW blockers are now not complete.

Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list