[Bug 434890] Review Request: LinLog - A ham radio logbook for linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: LinLog - A ham radio logbook for linux


https://bugzilla.redhat.com/show_bug.cgi?id=434890





------- Additional Comments From kanarip at kanarip.com  2008-02-26 05:14 EST -------
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK, GPLv2+
Actual License: OK, but source (src/linlog.cpp) says "GPL see COPYING file
shipped", COPYING file just says GPLv2
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match)
Compile and Build:
 - F-7: OK
 - F-8: OK
 - rawhide: OK
 - EL-5: FAILED: No package qt4-devel, but not a target, so it's OK.

Applicable Package Guidelines:
 - -debuginfo package: OK (~1.9M)

Locales: N/A
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: .pdf file (manual) included, not very large though: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

Problems:
The license of the package should be GPLv2 according to src/linlog.cpp, and I
can't find any other mention off 'GPL' or 'or later' in the code using a simple
'grep -rin <string> *'. Please let me know where it says v2+ if it is really v2+.

Another thing: You did well on the .desktop and icon file ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.