[Bug 426733] Review Request: Mediatomb - UPnP AV Mediaserver for Linux
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jan 2 16:43:00 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Mediatomb - UPnP AV Mediaserver for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=426733
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2008-01-02 11:42 EST -------
For 0.10.0-4:
Well, now for me your spec file is okay except for
- upnp_md5.{h.c} license issue
- Some cosmetic issues
* Well I was a bit just lazy but please put macros in braces
for consistency...
* And also for consistency please choose $RPM_BUILD_ROOT
or %{buildroot}, not using both.
Then as this is NEEDSPONSOR ticket:
-------------------------------------------------------------
NOTE: Before being sponsored:
This package will be accepted with another few work.
But before I accept this package, someone (I am a candidate)
must sponsor you.
Once you are sponsored, you have the right to review other
submitters' review requests and approve the packages formally.
For this reason, the person who want to be sponsored (like you)
are required to "show that you have an understanding
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
(at the time you are not sponsored, you cannot do
a formal review)
When you have submitted a new review request or have pre-reviewed other
person's review request, please write the bug number on this bug report
so that I can check your comments or review request.
Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")
Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list