[Bug 427162] Review Request: sagator - antivir/antispam gateway for smtp server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sagator - antivir/antispam gateway for smtp server


https://bugzilla.redhat.com/show_bug.cgi?id=427162





------- Additional Comments From ondrejj at salstar.sk  2008-01-03 15:23 EST -------
Thank you for review.

(In reply to comment #1)
>   sagator.noarch: W: spurious-executable-perm
> /usr/share/doc/sagator-1.0.0/test/policytest
>   sagator.noarch: W: file-not-utf8
/usr/share/doc/sagator-1.0.0/test/pack/rtest.zip
>   sagator.noarch: W: spurious-executable-perm
> /usr/share/doc/sagator-1.0.0/test/bigtest
> 
> Putting these scripts in %{_datadir}%{name} instead of %doc will quiet a lot of
> these complaints.  Perhaps an %{datadir}/%{name}/examples/ (or util) directory
> would be appropriate?

These files are used to test sagator's configuration after installation
(configuration). I think an user does not find them in
%{datadir}/%{name}/examples/ and therefore they are not useful.

I think these warnings are not fatal and can be ignored.
I can move whole "test" directory from docs to /usr/share, but with reduced
functionality.

It is better to remove them like move them to an hidden place.

>   sagator.noarch: W: symlink-should-be-relative /usr/share/sagator/etc/sgconf.py
> /etc/sagator.conf

Symlink updated to relative in next release.

> Why does the version in share link to the version in etc?  If it's an example,
> it should be duplicated in %doc and /etc.

Sagator uses python script for configuration. It is an modular system, which
defines more scanners with many parameters in an array. To use this file in
sagator, it need to be imported into python. That symlink adds sagator's
configuration file to it's project, to be easy to include it.

(In reply to comment #2)
> One other thing: your %install should rm -Rf %{buildroot}, per
> http://fedoraproject.org/wiki/Packaging/Guidelines (Prepping BuildRoot for
%install)

Thank you, fixed.
Last changelog:
* Thu Jan 3 2008 Jan ONDREJ (SAL) <ondrejj(at)salstar.sk> - 1.0.0-0beta32
- clean buildroot before install
- sagator.conf symlink is now relative

http://www.salstar.sk/pub/fedora/SPECS/sagator.spec
http://www.salstar.sk/pub/sagator/fedora/testing/8/SRPMS/sagator-1.0.0-0beta32.fc8.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.