[Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libvirt-cim - A CIM provider for libvirt


https://bugzilla.redhat.com/show_bug.cgi?id=421871


matt_domsch at dell.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review-              |fedora-review+




------- Additional Comments From matt_domsch at dell.com  2008-01-07 13:56 EST -------
Thanks for the quick turn.

Building on x86_64, I do see RPATHs being used.

$ find . -name \*.so | xargs -n 1 chrpath -l | grep RPATH
./usr/lib64/cmpi/libVirt_HostedDependency.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_AllocationCapabilities.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_VSMigrationService.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_VirtualSystemManagementService.so: 
RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_ComputerSystemIndication.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_ElementCapabilities.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_ResourcePoolConfigurationService.so: 
RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_SettingsDefineState.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_ElementConformsToProfile.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_VSSDComponent.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_SystemDevice.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_HostedService.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_HostedResourcePool.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_VirtualSystemManagementCapabilities.so: 
RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_SettingsDefineCapabilities.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_ElementAllocatedFromPool.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_ResourceAllocationFromPool.so: RPATH=/usr/lib64/cmpi
./usr/lib64/cmpi/libVirt_ElementSettingData.so: RPATH=/usr/lib64/cmpi

other trivial things:

rpmlint warning: libvirt-cim.x86_64: W: percent-in-%pre.
This comes from %pre's comment header mentioning %post.  Just drop the %.

Be sure spec file permissions are 644 when you cvs checkin to get rid of the 
other rpmlint warning.

A comment about .so files being plugins would be helpful.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.