[Bug 426599] Review Request: libgdl - Components and library for GNOME development tools
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jan 9 10:49:44 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libgdl - Components and library for GNOME development tools
https://bugzilla.redhat.com/show_bug.cgi?id=426599
alexl at users.sourceforge.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From alexl at users.sourceforge.net 2008-01-09 05:49 EST -------
- Package meets naming and packaging guidelines
- Spec file matches base package name.
- Spec has consistant macro usage.
- Meets Packaging Guidelines.
- License: (GPLv2 and GPLv2+ and LGPLv2+)
- License field in spec matches
- License file included in package
Only GPL included, LGPL also needed?
- Spec in American English
- Spec is legible.
- Sources match upstream md5sum: yes
- Package needs ExcludeArch
- BuildRequires correct
- Spec handles locales/find_lang
- Package has %defattr and permissions on files is good.
- Package has a correct %clean section.
- Package has correct buildroot
- Package is code or permissible content.
- Doc subpackage not needed
- Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
- Package compiles and builds on at least one arch.
- Package has no duplicate files in %files.
- Package doesn't own any directories other packages own.
- Package owns all the directories it creates.
- No rpmlint output.
- final provides and requires are sane
- Obsoletes seem sane:
Provides: anjuta-gdl = %{version}-%{release}
Obsoletes: anjuta-gdl < 0.7.7-1
Provides: anjuta-gdl-devel = %{version}-%{release}
Obsoletes: anjuta-gdl-devel < 0.7.7-1
SHOULD Items:
- Builds in koji using rawhide tag on all supported archs
- Sane scriptlets.
- Subpackages require base package with fully versioned depend.
- Has dist tag
Issues:
1. Minor: add: "Requires(post): /sbin/ldconfig"
2. Minor: Only GPL included, LGPL also needed?
Outstanding issues are minor, can be fixed after import:
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list