[Bug 427273] Review Request: firstaidkit - System Rescue Tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firstaidkit - System Rescue Tool


https://bugzilla.redhat.com/show_bug.cgi?id=427273





------- Additional Comments From jgranado at redhat.com  2008-01-09 11:54 EST -------
(In reply to comment #17)
> As, -devel only provides examples. I will suggest to create examples directory
> under %{_libdir}/firstaidkit-plugins and install example files there.
> so you just need to change following line in %install
> %{__cp} -rf plugins/ $RPM_BUILD_ROOT/%{_libdir}/firstaidkit-plugins
> to
> %{__install} -d $RPM_BUILD_ROOT/%{_libdir}/firstaidkit-plugins/examples
> %{__cp} -rf plugins/* $RPM_BUILD_ROOT/%{_libdir}/firstaidkit-plugins/examples

Was looking through your posted spec file, and you change this issue slightly by
putting the examples in %{_datadir} instead of %{_libdir}.  I would want them in
libdir and for sample3plugin/plugin to be executable so the plugin developer can
run the examples by calling firstaidkit `-execute=example1`.  What do you think?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.