[Bug 428410] Review Request: LADR - Library for Automated Deduction Research

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: LADR - Library for Automated Deduction Research


https://bugzilla.redhat.com/show_bug.cgi?id=428410





------- Additional Comments From leamas at bredband.net  2008-01-11 09:05 EST -------
This is just an informal review, you still need a sponsor. But here it is:

Naming: Since you are the upstream maintainer, I guess you are free to use LADR
instead of ladr. However, if there are no particular reasons to use capital
letters, uing lowercase would fit better into the Fedora naming scheme.

Licensing: GPL file included, GPL preamnble in all C files. No overall GPLL
statement for the complete package, no GPL header inn python scripts. Don't know
what to think about this, I'm a rookie.

testing. This package install ~35 files into /usr/bin. The docs are somewhat
hard to find - the reference to the manual in README.first is wrong, and the
programs don't understand standard '-h'/'..help' options. It's possible to
invoke some tools without segfaulting.  The website URL is fine. Once again,
don't know what to think

OK Rpmlint is silent
OK Spec file name.
OK Licensing.
OK License: field matches sw.
OK License included in doc.
OK Spec file in American English: I'm from Sweden, but to ny understanding...
OK Spec file legible
OK Source MD5sum: 6e2896ed4cce4556bfcc321778df5dfe upstream and in src.rpm
OK Builds on i386
OK See no reason to exclude architecture(s)
OK All build dependencies listed  (mock test OK)
OK Locales management - this package is not localized.
OK Libraries (no libraries in this package)
OK Not relocateble.
OK Owns it's directories.
OK No %file duplicates
OK File permissions
OK %clean target
OK Consistent macro usage
OK Code/permissive content (this is just code).
OK No large documentation
OK Doc's don't affect runtime.
OK No header files
OK No static libraries
OK No pkgconfig file(s)
OK No libraries
OK No devel package
OK Not a GUI application
OK Does not own other package's file/dirs.
OK rm -rf %{buildroot} in %install
OK Valid filenames (just ASCII)
OK No scriplets
OK No subpackages
OK No pkgconfig files
OK No file dependencies



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.