[Bug 428007] Package review: cronie

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: cronie


https://bugzilla.redhat.com/show_bug.cgi?id=428007


nphilipp at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?(mmaslano at redhat.co
                   |                            |m)




------- Additional Comments From nphilipp at redhat.com  2008-01-11 10:28 EST -------
CHECK:
- Summary and description contain bad English, summary is too long, I'd use:

Summary: Cron daemon for executing programs at set times

%description
Cronie contains the standard UNIX daemon crond that runs specified programs at
scheduled times and related tools. It is a fork of the original vixie-cron and
has security and configuration enhancements like the ability to use pam and
SELinux.

- URL in the spec file doesn't match new name (needs action from Fedora
  infrastructure)
- Add the epoch to "Obsoletes: vixie-cron <= 4.3" otherwise upgrading won't
  work (a missing epoch has the same effect as a zero epoch)
- Unnecessary build requirement on automake (you don't use it in the spec file,
  if the Makefiles try to rebuild themselves, there's something wrong)
- %preun mustn't fail, add ' || :' to the chkconfig command as well (it's
  always the last command that defines the exit code of a %pre/%post/un
  scriptlet)
- Get rid of the %triggerpostun, the vixie-cron version where it would trigger
  is older than RHEL2.1

Likely not harmful, but odd:
- I don't know why you have this in %build:

  CFLAGS="$RPM_OPT_FLAGS"; export CFLAGS
  [...]
  %configure \
  [...]

  If you use %configure, it already evaluates $RPM_OPT_FLAGS.
- what purpose does "make ... RPM_OPT_FLAGS="$RPM_OPT_FLAGS -DLINT -Dlint"
  have? Does the Makefile make use of $RPM_OPT_FLAGS (which wouldn't be good
  IMHO)?

I take it your working on the following issues in the course of you Makefile fixes:
- "make install" does much too few which you workaround in the spec file by
  creating directories, copying/moving stuff to the directories, I can help
  with automake/autofoo if you wish so "make install" just works
(possibly followup issues of the last one:
- no need to use %attr() for all the files if "make install" just does "the
  right thing"
- don't move files out of the source/build directory as it breaks "rpm -bi
  --short-circuit", just copy them, or better let them be installed with "make
  install"
- instead of renaming %{_sysconfdir}/pam.d/crond.pam to .../crond, just let
  "make install" do the right thing (i.e. install the file as "crond", not
  "crond.pam")
)

GOOD:
- pkg name issue fixed
- rpmlint checks return nothing
- license text and other documentation in %doc
- consistent use of macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.